[26.04_linux-nvidia-bos] watchdog: sbsa_gwdt: add early_enable module parameter - #558
[26.04_linux-nvidia-bos] watchdog: sbsa_gwdt: add early_enable module parameter#558kbutala-nv wants to merge 1 commit into
Conversation
BaseOS Kernel ReviewWarning
|
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 0063e504f570 │ watchdog: sbsa_gwdt: add early_enable module parameter │ match │ found │ ok, backporter: kbutala │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. PR metadata: E: PR targets 26.04_linux-nvidia-bos but body has no https://bugs.launchpad.net/... link |
6b2861b to
f92bed6
Compare
|
Is this patch needed for Vera too @kbutala-nv ? |
|
Same comment as in PR 557, please pick with -xs and append "linux-next" after the SHA. |
No, it is not needed for Vera |
On SBSA platforms using standard UEFI firmware (such as EDK II), the watchdog timer is often enabled during early boot stages but explicitly disabled by the firmware before handing over control to the OS (e.g., during ExitBootServices). This is done to prevent unintended resets while the OS is loading, assuming the OS watchdog driver will take over. However, this leaves a protection gap. If the system hangs between the firmware handover and the userspace watchdog daemon startup, the hardware watchdog will not fire to recover the system. For safety-critical systems that require continuous hardware watchdog protection from the earliest possible moment, this gap is problematic. Add an 'early_enable' module parameter to allow the kernel driver to re-enable the watchdog immediately during probe if it was left disabled by the firmware. By setting the WDOG_HW_RUNNING status bit, the watchdog core is instructed that the hardware is active. As a result, the core's pre-userspace handler (controlled by 'handle_boot_enabled') will automatically issue periodic keepalives until userspace opens the device. This bridges the protection gap seamlessly without requiring firmware modifications and without risking unintended resets during kernel boot. The parameter defaults to false to preserve the traditional behavior. Signed-off-by: Zexin Wang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Guenter Roeck <[email protected]> (cherry picked from commit 11f93e639d513cbfaa78237cd163039d27fea33c linux-next) Signed-off-by: Kaushal Rajeev Butala <[email protected]>
f92bed6 to
0063e50
Compare
done |
|
https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2166165
|
|
|
|
|
This PR contains backport of change https://patch.msgid.link/[email protected]
We need this patch to support newer firmware revisions.
(cherry picked from commit 11f93e639d513cbfaa78237cd163039d27fea33c linux-next)